Tuned hit finder parameters#912
Open
mattiasotgia wants to merge 3 commits into
Open
Conversation
cerati
reviewed
Jul 14, 2026
cerati
left a comment
cerati
left a comment
Contributor
There was a problem hiding this comment.
I left a couple of minor comments, should be easy to move to approval soon. Thanks!
| gaus_hitfinder_icarus.PeakFitter.tool_type: "PeakFitterMrqdt" | ||
| gaus_hitfinder_icarus.LongMaxHits: [1, 1, 1] | ||
| gaus_hitfinder_icarus.LongPulseWidth: [10, 10, 10] | ||
| gaus_hitfinder_icarus.LongMaxHits: [5, 6, 5] |
Contributor
There was a problem hiding this comment.
for my curiosity, how worse was a tuned version that disabled long hits?
Author
There was a problem hiding this comment.
I did not check this, but I'll put in my TODO list and get to it as soon as possible -- it should not take a long time to re-spin my small production with this small update and have some plots shared
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the updated hit finder parameters values obtained after the latest tuning.
Details can be found in the latest presentation given at the sim/reco ICARUS WG meeting, found on docdb-48139.
Description
This refactor the dependencies of the hit finder module across the FHiCL in stage1, removing the outdated sbn default and introducing the ICARUS-tailored version.
In
hitfindermodules_icarus.fclthe updated parameter values are set, and theNextADCThresholdparameter value is introduced for the candidate hit finder module.Depends on
This PR has been done as part of an infrastructure-wide attempt of freezing the code up to a certain version. The following is a list of (both closed/merged and open) PR that have been included as part of the validation studies.
Additionally, it requires the following to be merged to address some issues that we've been seeing on shower like topologies
PandoraPFA/larpandoradependency)This will also require
developto be on the same page asrelease/SBN2025Asince this was cut starting from there.Asking @acampani, @cerati and @SFBayLaser for a review.